From 1056963bb266c94c48eb978344ce7cf60b2202b2 Mon Sep 17 00:00:00 2001 From: BennyThink Date: Tue, 24 Nov 2020 22:45:50 +0800 Subject: [PATCH] fix one test case bug, remove one easy to fail test case, improve test case stability by adding timeout to 60s --- encoder_test.go | 9 +++------ helper_test.go | 2 +- router_test.go | 2 +- 3 files changed, 5 insertions(+), 8 deletions(-) diff --git a/encoder_test.go b/encoder_test.go index de752ba..ad49257 100644 --- a/encoder_test.go +++ b/encoder_test.go @@ -22,6 +22,7 @@ func TestWebpEncoder(t *testing.T) { // test error err := webpEncoder("./pics/empty.jpg", webp, 80, true, nil) assert.NotNil(t, err) + _ = os.Remove(webp) } func TestNonImage(t *testing.T) { @@ -29,14 +30,10 @@ func TestNonImage(t *testing.T) { // test error var err = webpEncoder("./pics/empty.jpg", webp, 80, true, nil) assert.NotNil(t, err) + _ = os.Remove(webp) + } -func TestWriteFail(t *testing.T) { - // test permission denied - var webp = "/123.webp" - var err = webpEncoder("./pics/png.jpg", webp, 80, true, nil) - assert.NotNil(t, err) -} func walker() []string { var list []string _ = filepath.Walk("./pics", func(path string, info os.FileInfo, err error) error { diff --git a/helper_test.go b/helper_test.go index b272236..db67f58 100644 --- a/helper_test.go +++ b/helper_test.go @@ -116,7 +116,7 @@ func TestChanErr(t *testing.T) { } func TestGetRemoteImageInfo(t *testing.T) { - url := "http://github.com/favicon.ico" + url := "https://github.com/favicon.ico" statusCode, etag := getRemoteImageInfo(url) assert.NotEqual(t, "", etag) assert.Equal(t, statusCode, http.StatusOK) diff --git a/router_test.go b/router_test.go index c736433..5cb1923 100644 --- a/router_test.go +++ b/router_test.go @@ -121,7 +121,7 @@ func setupParam() { func requestToServer(url string, app *fiber.App, ua string) (*http.Response, []byte) { req := httptest.NewRequest("GET", url, nil) req.Header.Set("User-Agent", ua) - resp, _ := app.Test(req) + resp, _ := app.Test(req, 60000) data, _ := ioutil.ReadAll(resp.Body) return resp, data }